Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beam to 2.56 #5346

Merged
merged 5 commits into from
May 6, 2024
Merged

Update beam to 2.56 #5346

merged 5 commits into from
May 6, 2024

Conversation

RustedBones
Copy link
Contributor

No description provided.

Comment on lines +3 to +4
"type": "record",
"name": "AvroGeneratedUser",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did the Beam Avro class get deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact is published with a class compiled with another, incompatible avro version

@RustedBones RustedBones marked this pull request as ready for review May 6, 2024 10:30
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.23%. Comparing base (b544c6d) to head (5a4ca5e).

Files Patch % Lines
...ify/scio/coders/instances/kryo/GcpSerializer.scala 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5346   +/-   ##
=======================================
  Coverage   61.22%   61.23%           
=======================================
  Files         302      302           
  Lines       10846    10850    +4     
  Branches      761      761           
=======================================
+ Hits         6641     6644    +3     
- Misses       4205     4206    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones RustedBones merged commit 7de1259 into main May 6, 2024
11 checks passed
@RustedBones RustedBones deleted the beam-2.56 branch May 6, 2024 12:50
clairemcginty pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants